Detect if the X server is XWayland and report an error. #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: Detect if $DISPLAY env is not set and report a more informative error message. For the purposes of libxdo/xdotool, XWayland does not work, so it's best to notify the user accordingly if detected. This adds a dependency on XInput `libxi` because the only[1] way I have found to detect XWayland is through this extension [1] There is another detection method which uses XFree86-VidModeExtension, but I don't know how common that extension is compared to XInput2. Fixes #341. Related to #337.
|
With this change, the following errors are now present: When XWayland is detectedWhen DISPLAY is empty |
|
I just noticed that |
This was referenced Aug 3, 2021
Closed
buldi
pushed a commit
to buldi/xdotool
that referenced
this pull request
Apr 23, 2022
…#342) * Detect if the X server is XWayland and report an error. Also: Detect if $DISPLAY env is not set and report a more informative error message. For the purposes of libxdo/xdotool, XWayland does not work, so it's best to notify the user accordingly if detected. This adds a dependency on XInput `libxi` because the only[1] way I have found to detect XWayland is through this extension [1] There is another detection method which uses XFree86-VidModeExtension, but I don't know how common that extension is compared to XInput2. Fixes jordansissel#341. Related to jordansissel#337. * xdo_version.h update when VERSION updates * Fix typo in version.sh which leaves an extra plus '+' character in the date * Run help or version commands without trying to connect to the X11 display * Free when detecting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: Detect if $DISPLAY env is not set and report a more informative
error message.
For the purposes of libxdo/xdotool, XWayland does not work, so it's best
to notify the user accordingly if detected.
This adds a dependency on XInput
libxibecause the only[1] way I havefound to detect XWayland is through this extension
[1] There is another detection method which uses
XFree86-VidModeExtension, but I don't know how common that extension is
compared to XInput2.
Fixes #341.
Related to #337.