Add windowquit option and get tests working #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send a _NET_WINDOW_CLOSE event to a given window. This allows for a graceful window shutdown, as opposed to the existing windowclose, which is too rude, and windowkill, which is too lethal. Signed-off-by: Antonio Russo <aerusso@aerusso.net>
assert_not_equal is not defined in minitest. Provide it in xdo_test_helper.rb. Signed-off-by: Antonio Russo <aerusso@aerusso.net>
aerusso
changed the title
|
Code looks good, thanks! I tested with |
buldi
pushed a commit
to buldi/xdotool
that referenced
this pull request
Apr 23, 2022
* Add windowquit option Send a _NET_WINDOW_CLOSE event to a given window. This allows for a graceful window shutdown, as opposed to the existing windowclose, which is too rude, and windowkill, which is too lethal. Signed-off-by: Antonio Russo <aerusso@aerusso.net> * Add assert_not_equal ruby test function assert_not_equal is not defined in minitest. Provide it in xdo_test_helper.rb. Signed-off-by: Antonio Russo <aerusso@aerusso.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send a
_NET_WINDOW_CLOSEevent to a given window. This allows for a graceful window shutdown, as opposed to the existing windowclose, which is too rude, and windowkill, which is too lethal.