-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yara/Logging/Misc Fix Updates #14
base: master
Are you sure you want to change the base?
Conversation
…ry 'yara' and bug which ran Yara even if it wasn't enabled)
Thanks for the pull request, nice work! Can you take a look at the Travis CI Build results? I am getting the same results when I try to run the tool locally. The error message states: |
Ah I see the problem, I had Yara installed previously so it dropped the library on my system. Looks like it requires libyara to be installed on Ubuntu systems (simple |
…mported for any reason
Thought just occurred to me. The Yara functionality needs to be truly optional especially given the opt-in command line switch. So I went ahead and added a graceful try-except that disables Yara if the import isn't graceful. We should still include a note somewhere in the instructions (I'll leave this up to your better discretion) but basically say "You need to fully install the Yara libraries to get this support" |
Is there anything still blocking this PR merge ? |
Nice project. Fixed/Updated a couple of things for you: