add bias tee check box on device settings

[sophiekovalevsky]

This tool is insanely amazing =) congrats on all the effort to pull all this off like a pro.

This PR implements a feature that is was requested way back (#703) however, sadly at my lab I only have bladeRF v1 generation. The implementation should work setting up both bias tee on rx and tx side.

Being said that, @jopohl there is any chance that you could have both bias tee module to test this locally at your lab?

fix #703

[CLAassistant]

All committers have signed the CLA.

[jopohl]

Thanks Kiara and great job getting started with that PR!

Unfortunately, I have no BladeRF v2 to test here, this is the main thing that always hold me back from implementing this myself. Maybe someone from the community can jump it? Would be great if we could find someone to test this.

[sophiekovalevsky]

@jopohl thanks for taking a closer look at this. Let me announce this into the community to see if someone can help me to achieve this. Otherwise, I'm guessing this wouldn't be able to be merged, right?

[kaipyroami]

I have a v2 xA9, BT-200, and BT-100. I'm wiling to help if I can.

[sophiekovalevsky]

I have a v2 xA9, BT-200, and BT-100. I'm wiling to help if I can.

That's awesome @kaipyroami. Would you mind to test the latest commit on this branch? And verify the following,

With BT-200

1. Go to File -> Sniff Protocol -> Tick Bias Tee
2. Hit Start button

Does the green led on BT-200 is on?

With BT-100

1. Go to File -> Open -> Select your the waveform file
2. Under interpretation -> Hit "Play" button within Complex Signal.
3. Tick Bias Tee

Does the blue led on BT-100 is on?

[kaipyroami]

Ok, so all tests passed

I have a v2 xA9, BT-200, and BT-100. I'm wiling to help if I can.

That's awesome @kaipyroami. Would you mind to test the latest commit on this branch? And verify the following,

With BT-200

1. Go to File -> Sniff Protocol -> Tick Bias Tee
2. Hit Start button

Does the green led on BT-200 is on?

With BT-100

1. Go to File -> Open -> Select your the waveform file
2. Under interpretation -> Hit "Play" button within Complex Signal.
3. Tick Bias Tee

Does the blue led on BT-100 is on?

All tests passed per this procedure. Green and blue LEDs function as expected with the exception of needing to toggle the check boxes sometimes. Might just be a GUI issue but I'm not entirely sure.

When recording and leaving the bias-tee checkbox checked it will appear checked when opening the play window. The checkbox must be unchecked and then rechecked for it to take effect.

[sophiekovalevsky]

@kaipyroami I was able to reproduce the issue you mentioned, and it was a GUI behavior indeed. Would you mind to test again with the new changes that I've pushed?

@jopohl let me know if I'm wrong but I would expect to maintain the same value when choosing bias tee for the entire session, i.e. if I open up Spectrum Analyzer, and then Record Signal for example. The fallback when another session is open would be False.

I've set an update in checking the bias tee value when signals are triggered so that this can be propagate to the device.

[kaipyroami]

Bias tee issue fixed.

[sophiekovalevsky]

Bias tee issue fixed.

Amazing, thanks you again to test this out.

[kaipyroami]

Bias tee issue fixed.

Amazing, thanks you again to test this out.

Thank you for adding features to my SDR! Cheers!

[jopohl]

Looks good, great job! Did you test this again with your BladeRF after addressing the review?

[kaipyroami]

Looks good, great job! Did you test this again with your BladeRF after addressing the review?

I'll test it again with my device and report back.

[kaipyroami]

Looks good. No problems that I can see.

[sophiekovalevsky]

Looks good. No problems that I can see.

Awesome. Thanks to test again @kaipyroami

@jopohl I tested again with my bladeRF x40 and I didn't find any issues.