Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for participant assignment when loading project with hidden messages #308

Merged
merged 3 commits into from
Jul 13, 2017
Merged

Bugfix for participant assignment when loading project with hidden messages #308

merged 3 commits into from
Jul 13, 2017

Conversation

jopohl
Copy link
Owner

@jopohl jopohl commented Jul 13, 2017 •
edited
Loading

This PR fixes a bug where participants do not get assigned properly to previously hidden messages, when loading a project.

@jopohl jopohl requested a review from andynoack July 13, 2017 07:35
andynoack
andynoack approved these changes Jul 13, 2017
View reviewed changes
Copy link
Collaborator

@andynoack andynoack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

  • new bug? CRC polynomial is set to default when editing

@jopohl jopohl merged commit 3754ea8 into master Jul 13, 2017
@jopohl jopohl deleted the project_load_bugfix branch July 13, 2017 09:12
@jopohl
Copy link
Owner Author

jopohl commented Jul 14, 2017

CRC polynomial useability issue was fixed with #311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andynoack andynoack andynoack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jopohl @andynoack