Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default NRZi decoder configured incorrectly #775

Closed
hllhll opened this issue May 19, 2020 · 3 comments
Closed

Default NRZi decoder configured incorrectly #775

hllhll opened this issue May 19, 2020 · 3 comments

Comments

@hllhll
Copy link

hllhll commented May 19, 2020

Expected Behavior

NRZ-i Decoder should perform NRZ-i (or NRZi) decoding, I.E. A change from x->!x is 1, else 0
0100011110 should translate into
110010001

Actual Behavior

Instead it just inverts the data (Invert stock decoding)

Additional info:

It seems that the stock software decoder for NRZi is configured as invert and not as differential encoding
@andynoack
Copy link
Collaborator

Thanks for the hint, i just fixed it!

andynoack added a commit that referenced this issue May 19, 2020
@andynoack
Change NRZ-I decoding from invert to differential encoding (see e.g. h…
9fe6836 
…ttps://en.wikipedia.org/wiki/Non-return-to-zero). Fix #775
@andynoack andynoack mentioned this issue May 19, 2020
Merged
andynoack added a commit that referenced this issue May 19, 2020
@andynoack @jopohl
Remove NRZ-I to prevent mixing with NRZ + Invert, clarify names. (#776)
1d3981c 
* Change NRZ-I decoding from invert to differential encoding (see e.g. https://en.wikipedia.org/wiki/Non-return-to-zero). Fix #775

* skip bugged cython version

* Remove "Non Return To Zero Inverted (NRZ-I)" due to contradictory definitions in literature.

Co-authored-by: jopohl <Johannes.Pohl90@gmail.com>
@hllhll
Copy link
Author

hllhll commented May 21, 2020 •
edited
Loading

I Guess this is also another way to fix :)

While I'm here I must say this is an incredible piece of software, for my current project i'm using virtually ALL OF THE PROGRAM FEATURES! without writing single line of code. (Except for maybe auto-analyze)

@andynoack
Copy link
Collaborator

Yes, we discussed it internally and found several resources with different NRZ-I definitions. We think, it is the best solution to avoid the name NRZ-I to not confuse anyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hllhll @andynoack