Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to merge development history from openjscad.org #82

Closed
wants to merge 2 commits into from

Conversation

apla
Copy link
Collaborator

@apla apla commented Jun 16, 2016

Hi!

I've started to merge development histories to make one very good codebase instead of three just good:

This patch set separate viewer from openscad.js and now viewer supports both three.js and lightgl.js renderers. I'm preparing patch for openjscad.org too.

Another major change is configuration system — now it allows to configure much more, please take a look defaults function from openscad.viewer.js

Minor features:

  • Display configurable grid;
  • HiDPI display support;
  • Old options format is supported;
  • Colors in configuration can be configured using html hex notation #xxyyzz

@joostn
Copy link
Owner

joostn commented Jun 22, 2016

Hi Apla,

Would you be willing to do the merge yourself? I don't have time, basically nobody is currently maintaining joostn/OpenJsCad.

@apla
Copy link
Collaborator Author

apla commented Jun 22, 2016

Yes, I will. Thank you!

@dav-m85
Copy link

dav-m85 commented Jan 6, 2017

Hey, any news on this one ? @apla @joostn ? I would be happy to provide some help if needed.

@apla
Copy link
Collaborator Author

apla commented Jan 6, 2017

I've rewritten my patch for OpenJSCAD.org, but this patch also need to be rewritten slightly. I'll try my best to finish it in coming week or so.

@z3dev
Copy link
Collaborator

z3dev commented Mar 11, 2017

@apla Given that CSG.js is now part of the JSCAD organization, I believe that this PR is no longer necessary here.

@joostn Would like these changes merged? This might help keep your web interface to current.

@z3dev z3dev closed this Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants