Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use wallpaper extractor #69

Closed
demoran23 opened this issue Dec 16, 2021 · 6 comments
Closed

Unable to use wallpaper extractor #69

demoran23 opened this issue Dec 16, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@demoran23
Copy link
Contributor

With the end of the year coming up, I gave the wallpaper generator a shot and I got a null reference exception and a blank page. The thing is, even when I pull down the latest code and use that, I still get the same thing, and I'm at a loss as to why.

Audible Library Extractor Data.zip

@demoran23
Copy link
Contributor Author

demoran23 commented Dec 17, 2021

Here's what I see when I open the wallpaper extractor:

image

I've tried clearing localstorage, tried incognito, and tried disabling all of my other extensions. It looks like that div isn't mounted on the dom.

In fact, here's what the dom looks like when I put a breakpoint there:

image

@joonaspaakko
Copy link
Owner

joonaspaakko commented Dec 17, 2021

@demoran23, I can't seem to find anything wrong with it. The weirdest thing about what you've shared so far is the last screenshot and the empty comment. In Vue, this empty comment (usually) means that the spot is reserved for an element that is currently "hidden".

Now the thing about that is, there should be a static element where the empty comment is. It's the root element that comes from the HTML file and is not created (or removed) programmatically.

So then, I think the first question is... Why is it not there?

Since you have access to the project source, I'd like you to try removing the two script lines (17, 18), just to confirm if the app's own code is somehow malfunctioning and removing that static element.

Where to go from there, I don't know.

@demoran23
Copy link
Contributor Author

With the js commented out:

image

This happens regardless of whether the polyfill is commented or not.

@joonaspaakko
Copy link
Owner

joonaspaakko commented Dec 17, 2021

So it is something in the wallpaper-creator.js (technically at least). I was kinda hoping something else.

I can't remember if you said so, but did you download the release build or just clone the repo? Because if you try the release build v.0.2.7 in Chrome with your data and it doesn't work... And I've tried the same release build in Chrome with your data but it works... How could that be? The only variable left would be perhaps the browser version or maybe the installation method... If we're reaching. And we already ruled out local storage data.

I'm kinda leaning towards you perhaps cloning or pulling the repo and tripping on some dev quirk. Like maybe you didnt do npm install or something.

@demoran23
Copy link
Contributor Author

Unfortunately I first hit my head against this using the version from the chrome webstore. So it was the release build. And I'm doing by tests from the dist folder after building locally. I've got the latest version of Chrome (Version 96.0.4664.110 (Official Build) (64-bit)).

Remember, the way I'm getting to the wallpaper creator page in the first place is by going to Audible, clicking on the link to open the gallery, and then clicking on the wallpaper creator button, so if it failed to build locally, then I wouldn't be able to get that far in the first place, which would mean that we'd never see the null reference exception.

Let me know if you're interested in a screen share sometime; we could try to troubleshoot it together. I wonder if I'm the only one with this issue.

@joonaspaakko
Copy link
Owner

joonaspaakko commented Dec 17, 2021

I didn't mean to suggest the build failed (entirely). Something very specific to the wallpaper creator could've broken (or something), like the thing with saving the standalone gallery. At the very least it has way more things that could go wrong than us both using the release build. Yet it behaves differently.

I've tried the release build on a couple different versions of Firefox and Chrome on Mac and Windows with your data. I'm using the same chrome version. It should be the same exact scenario...

I'll contact you about screen sharing or something if I get any ideas, but I don't have any right now (aside from maybe removing components one by one until it works with what it's got).

I've not had any other complaints, but I have no idea if anyone else other than me has used it succesfully.

demoran23 added a commit to demoran23/audible-library-extractor that referenced this issue Dec 18, 2021
@joonaspaakko joonaspaakko added the bug Something isn't working label Dec 19, 2021
joonaspaakko added a commit that referenced this issue Dec 19, 2021
joonaspaakko added a commit that referenced this issue Jan 1, 2022
- Some additional changes to #69 now that my mind is a bit clearer.
- Made the "You should remove and re-extract data" hide if the data version is 0.2.7 or 0.2.8 (clunky I know...)
- Fixed (again) the "audible library extractor" link that opens the extension settings. It jumped 1 row down so I just gave it more room. Now it's drastically different
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants