Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My books in the series list: links lead to empty pages inside the gallery #48

Closed
joonaspaakko opened this issue May 18, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@joonaspaakko
Copy link
Owner

joonaspaakko commented May 18, 2021

Basically, if you go to any of the subpages and click the Wishlist button, the data source is now globally the wishlist, so when you go back to the library and try to click a book in the My books in the series list, it can't show the books in the series because it's trying to find them from the wishlist.

This is a sticky value that doesn't expire until cache is cleared or the data source is changed back to Library.

Currently you can work around this issue by opening any subpage from the menu and changing the source by clicking the "library" button:

@joonaspaakko joonaspaakko added the bug Something isn't working label May 18, 2021
joonaspaakko added a commit that referenced this issue Jul 7, 2021
- First of all my last fix was malfunctioning a bit, but now it also works differently. So whenever you change the sub page source, it remembers the state, but a url param will overwrite that. So now you can switch sub page source to wishlist and it won’t change on its own when you click a book link in the “my books in the series” link.

- There was also an attempt to find free books in a series during extraction, but I wasn’t able to test this. Maybe it works… Idk..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant