Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock keeps spinning after all tasks completed #130

Closed
bwims opened this issue Sep 19, 2023 · 22 comments
Closed

Clock keeps spinning after all tasks completed #130

bwims opened this issue Sep 19, 2023 · 22 comments
Labels
bug Something isn't working Priority: High

Comments

@bwims
Copy link

bwims commented Sep 19, 2023

Hi,

My account is on audible.co.uk , if that makes a difference?

All tasks completed but the process then hangs with the clock spinning and gallery never appears.

I have disabled ad blocker and cookie trackers but no joy.

B.

@bwims
Copy link
Author

bwims commented Sep 19, 2023

After reading further, I thought this might be helpful

image

@joonaspaakko
Copy link
Owner

joonaspaakko commented Sep 19, 2023

The good news is that I think I know where the issue is coming from. The bad news is you have to wait for me to make a new build that fixes it (and also I think many people may experience this same issue). I'll try to fix it later today.

@bwims
Copy link
Author

bwims commented Sep 19, 2023

Great! Thanks!

joonaspaakko added a commit that referenced this issue Sep 19, 2023
```
Uncaught (in promise) TypeError: Cannot read properties of undefined
(reading 'join')
```
@joonaspaakko
Copy link
Owner

joonaspaakko commented Sep 19, 2023

Could you try this dev build?

Installation instructions:

  1. Download the 0.2.10 draft
  2. Go to the address: chrome:extensions
    • or from the menu in top right: ⋮ > Extensions > Manage extensions
  3. Enable the developer mode from the top right
  4. Drag the downloaded .zip file into the browser window to install

@bwims
Copy link
Author

bwims commented Sep 21, 2023 via email

@joonaspaakko
Copy link
Owner

joonaspaakko commented Sep 21, 2023

@bwims, I think the issue might be importing the CSV with Excel's default encoding Western 1252. At least that's how I was able to get ’ and ∞ to show up in my text editor. If I open the CSV with UTF-8 encoding it looks normal.

image

Or if that doesn't work, I think sheets.google.com would potentially work better. I believe it prefers UTF-8. Funny enough, looking into this I found many articles for Excel users saying something like "If you see weird characters in your CSV file in Excel, import the file to Google Sheets because it opens files with UTF-8 encoding, download it as an Excel file and now it shows up properly in Excel", which seems a bit silly for many reasons; you could just use Google Sheets and Excel also has its own import encoding option File Origin (as shown in the picture).


What concerns me a little is:

Interestingly, your gallery displays the book number of the series in
brackets, except when it is an infinity symbol, so I assume it is some kind
of flag.

By brackets do you mean something like [1] or [1,2,3] or maybe ["1", "2"]? This can happen sometimes when rendering an array as such and definitely isn't on purpose. It could've happened with the changes that I made on the v.0.2.10 draft, but I'm not seeing any brackets around book numbers with my test data. I would be interested to see a screenshot of what you're seeing.

This is what I'm seeing in the gallery:

1 2

image

@bwims
Copy link
Author

bwims commented Sep 21, 2023

All points on encoding well taken.

Regarding book number, brackets aren't the problem.  
Ex 1

This book has the value "∞" (∞) in the field "Book Numbers" of the CSV export

Note that there is no book number in brackets

image

However, this book has the number 8 in the field "Book Numbers" of the CSV export
and displays (book 8) in brackets.

image

But it isn't a big deal - just a curiosity!

Thanks!

B.

@bwims
Copy link
Author

bwims commented Sep 21, 2023

PS your text import example worked wonderfully! ( and it is the infinity symbol!)

@bwims
Copy link
Author

bwims commented Sep 21, 2023

PPS, Would it be possible to include date of purchase? Or is that another dataset?

@joonaspaakko
Copy link
Owner

joonaspaakko commented Sep 21, 2023

Oh I see... That's a relief. Apparently, I think of () as parenthesis and [] as brackets (or square brackets), hence the confusion.

So yeah, the brackets are there on purpose. They are supposed to further indicate that this is the book number and not part of the series name all the while not trying to break the listing of series names, since some books are part of multiple series. Logically you can probably easily figure out "book x" is not part of the series name, but I mean just visually I think it increases readability.

Audible does this:

This is a series, book 1, Another series the book is in but has no number in it, A third series the book is in, book 6

I just don't like it so the gallery shows it like:

This is a series (book 1), Another series the book is in but has no number in it, A third series the book is in (book 6)

My gallery, my rules... I guess :)

Why the first book in your screenshot doesn't have a number in brackets is probably because it doesn't have a number in Audible, either on purpose or it's a mistake. Sometimes the store page even displays a different number than the series page. I checked: Memory's Legion has no book number in Audible.

As far as the CSV export goes, it just kind of exports it as is, but I've been meaning to add a separate column for just the series name(s) without book numbers.

@joonaspaakko
Copy link
Owner

joonaspaakko commented Sep 21, 2023

PPS, Would it be possible to include date of purchase? Or is that another dataset?

Tl;Dr yes, it's on my to-do list.

The website library as well as the store page used to display date added until a few years ago. They took it away when they modernized the library page.

For v.0.2.9 I was supposed to add an extraction for the purchase history pages, but too many issues piled up and I didn't have the time, given that the time was ticking and the extraction was broken for everyone. Now it's back on the to-do list but I won't make promises on when or even if it will actually be added, only that I will see what I can do... At some point.

@bwims
Copy link
Author

bwims commented Sep 22, 2023

Re Book number, I had assumed what you say. I guess I said it in a confusing way. My whole point was to conjecture that the infinity symbol is there to flag a book in a series but without a book number.

I really appreciate your efforts. I feel very angry with Amazon for their arbitrary changes and not providing the data extraction facilities in an easy way. They used to have an indicator to show when a book had been downloaded or not, but no longer.

It must be a real labour of love for you!

Thanks!

B.

@joonaspaakko
Copy link
Owner

joonaspaakko commented Sep 22, 2023

I hadn't even noticed the downloaded status was taken away... Good to know.

It is a labor of lover/hate/necessity. Audible, especially the mobile apps, have caught up quite a bit in recent years, but there are still many things that ALE gallery is better at. So I still use it on my phone for browsing my library to find the next book, click a link that opens the book I found in Audible's mobile app, which I use just for listening.

Though I recognize the wallpaper creator (in the gallery menu "extension tools") is very niche and not at all necessary, I'm very fond of it too. I've made animated wallpapers and screensavers for all my computers. Admittedly, I've never really used the CSV export myself and it was pretty much just an afterthought.

@bwims
Copy link
Author

bwims commented Sep 23, 2023

It was a great afterthought!

Thanks for all you help!

@joonaspaakko joonaspaakko added bug Something isn't working Priority: High labels Sep 28, 2023
@TheSidXXX
Copy link

I was having the same issue, and the 2.10 version linked above solved it for me. Weird glitch, Audible and the tool both say I have 1738 books, but once the gallery was generated it only shows 1734. Not sure of an easy way to figure out which 4 aren't in there, but if I do figure it out, I'll let you know.

@joonaspaakko
Copy link
Owner

joonaspaakko commented Sep 29, 2023

@TheSidXXX, off the top of my head my best guess is that you have 4 podcasts on the "podcasts" page.

The extraction goes through the gallery on the "All titles" tab just because there wasn't a reason not to. Now that it includes podcasts it really should show the counters somehow separately to avoid confusion.

If you don't think that is the reason, maybe try extracting again (without removing any data beforehand).

@TheSidXXX
Copy link

@TheSidXXX, off the top of my head my best guess is that you have 4 podcasts on the "podcasts" page.

The extraction goes through the gallery on the "All titles" tab just because there wasn't a reason not to. Now that it includes podcasts it really should show the counters somehow separately to avoid confusion.

If you don't think that is the reason, maybe try extracting again (without removing any data beforehand).

That looks like it! I have 4 podcasts on there.

Another weird issue, I thought everything worked, but when I go to the series page, nothing loads. I can see some thumbnails in the background, but the actual list of series doesn't load. Authors, narrators, publisher, category all work, but series doesn't. Since there are series screenshots in this thread, I'm guessing it's something on my end.

@joonaspaakko
Copy link
Owner

joonaspaakko commented Sep 29, 2023

@TheSidXXX, could you export your raw data from the extraction settings and send that to me? You can attach it here or email it to me if you don't feel like sharing it publicly, though it doesn't contain anything more than the standalone gallery website data, it's just formatted differently. My email is in my Github profile.

@TheSidXXX
Copy link

@TheSidXXX, could you export your raw data from the extraction settings and send that to me? You can email it to me, though it doesn't contain anything more than the website data, it's just formatted differently. My email is in my Github profile.

I removed all extracted data and reran it, and series worked this time. I can still send if you want, but it looks like it's been resolved.

@joonaspaakko
Copy link
Owner

joonaspaakko commented Sep 29, 2023

@TheSidXXX, no need in that case, but if it happens again...

I'm maybe planning to make a quick new release soon because of this #130 issue, but I'd rather not just swap it with another, so if you or I guess anyone else gets the series page is blank issue again, I'd appreciate the raw data.

@TheSidXXX
Copy link

@joonaspaakko I still have the zip file of the gallery that had the issue, would that be helpful?
ALE-gallery (7).zip

@joonaspaakko
Copy link
Owner

That should do it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: High
Projects
None yet
Development

No branches or pull requests

3 participants