[6.0] Remove instances of Table::getInstance() from core code #44090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
approved these changes
Sep 19, 2024
|
Looks for me like a BC break as the getInstance function does a lookup in the container for instances. |
laoneo
added
the
b/c break
|
You are right, I will convert this to 6.0-dev. |
Hackwar
changed the title
# Conflicts: # administrator/components/com_admin/script.php
|
Tested this on downloaded patch with user add and article ... worked as described. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Table::getInstance()has been deprecated some time ago and this PR removes most instances where this is used in the Joomla core.Testing Instructions
Test that everything still works. Since this code is used nearly everywhere, there aren't really any more precise instructions.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Adding switch from Table::getInstance to explicit class invocation Manual#377
No documentation changes for manual.joomla.org needed