fixes hover issues #351
Merged
fixes hover issues #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roland-d
reviewed
Oct 15, 2022
administrator/components/com_patchtester/PatchTester/View/Pulls/tmpl/default_items.php
Outdated
Show resolved
Hide resolved
|
Thanks |
|
@roland-d would you tag it for hacktoberfest please |
|
@N6REJ Done |
|
@roland-d nope, didn't work. I think its the wrong label. |
|
@N6REJ How about now? |
|
I think so, yes.. ty.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
#340
Summary of Changes
By default badges do not have hover styling
so in order to do so we have the choice of creating a new .css file and adding our own stylings or use the inbuilt bs5 button behavior. I chose the latter.
The effect is subtle but this is due to how atum handles things. This issue would be best for @JaT
Testing Instructions
install patch tester.
apply patch
notice the subtle shift in background color & flicker on hover