Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

314 missing pulls #315

Merged
merged 3 commits into from
Mar 4, 2021
Merged

Conversation

weeblr
Copy link

@weeblr weeblr commented Mar 1, 2021

Pull Request for Issue #314 .

Summary of Changes

Use pulls rest API endpoint instead of issues endpoint to fetch the list of PRs. Using issues endpoint caused only a subset of PRs to be retrieved.

Testing Instructions

Applying change make last 100 PR (batchsize) to be listed in the patch tester admin.

@weeblr
Copy link
Author

weeblr commented Mar 4, 2021

@roland-d Can you make sure to pull that one in as well? Joomla 3 version has the same problem as the J4 version. Thanks

@richard67
Copy link

@weeblr Maybe you can fix code style before? You have removed an if condition around a code block, so that code block needs one level = one tab less indentation:
https://github.com/joomla-extensions/patchtester/pull/315/files#diff-52387c1e54fadcf3939c94d09d0c914e6eaffd024fe8fd3f47ac4bc289ab01e1R373-R399

@weeblr
Copy link
Author

weeblr commented Mar 4, 2021

@richard67 I have attempted to reformat, I'm doing it in Github directly, not the easiest there.

@richard67
Copy link

@weeblr Looks ok here locally with an editor which shows tabs and spaces (if I want that). Not easy in the GitHub UI, I agree. Thanks so far.

I don't know if and when @roland-d 's plans a 3.0.0 release.

@weeblr
Copy link
Author

weeblr commented Mar 4, 2021

Well I hope he does cause that's where the problem lies for me and at least on issue solved but pending tests. I have testers, they spent times trying to start using patchtester only to find it would not show the PR I was asking them to test.

Wonder how this has affected the development and testing of Joomla 4 indeed, this has likely been going on for a while now. If people did not see PR in the patchtester, then obviously they could not test them!

@roland-d roland-d merged commit 1150811 into joomla-extensions:3.0 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants