fix: check the url can be undefined Close #224

joolfe · Sep 24, 2022 · cb6e53b · cb6e53b
1 parent 8799631
commit cb6e53b
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 4 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -396,7 +396,7 @@ function calculateDomains (protocol, hosts, port) {
  */
 function scrapeURL (url) {
   // Avoid parse empty url request
-  if (url === '' || url.raw === '') {
+  if (url === undefined || url === '' || url.raw === '') {
     return { valid: false }
   }
   const rawUrl = (typeof url === 'string' || url instanceof String) ? url : url.raw

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "postman-to-openapi",
-  "version": "2.7.0",
+  "version": "2.7.1",
   "description": "Convert postman collection to OpenAPI spec",
   "main": "lib/index.js",
   "types": "types/index.d.ts",

diff --git a/test/resources/input/v2/PostmantoOpenAPI.json b/test/resources/input/v2/PostmantoOpenAPI.json
@@ -61,6 +61,14 @@
 				"description": "Just an example of text raw body"
 			},
 			"response": []
+		},
+		{
+			"name": "No url request",
+			"request": {
+				"method": "GET",
+				"header": []
+			},
+			"response": []
 		}
 	],
 	"event": [

diff --git a/test/resources/input/v21/PostmantoOpenAPI.json b/test/resources/input/v21/PostmantoOpenAPI.json
@@ -91,6 +91,14 @@
 				"description": "Just an example of text raw body"
 			},
 			"response": []
+		},
+		{
+			"name": "No url request",
+			"request": {
+				"method": "GET",
+				"header": []
+			},
+			"response": []
 		}
 	],
 	"event": [