forked from dotnet/java-interop
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[generator] Output correct formatting for binding warnings (dotnet#737)
In d664e90 we refactored some output around binding warning messages in order to better support localization. Unfortunately this refactoring left out a period between some type and member names: warning BG8700: Unknown return type 'Android.App.Admin.AppOpsManagerMode' for member 'Android.App.AppOpsManagerUnsafeCheckOp (java.lang.String, int, java.lang.String)'. `Android.App.AppOpsManagerUnsafeCheckOp` should instead be `Android.App.AppOpsManager.UnsafeCheckOp`. Fix `CodeGeneratorContext.GetContextTypeMember()` so that `.`s are inserted everywhere required.
- Loading branch information
Showing
2 changed files
with
51 additions
and
6 deletions.
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
tests/generator-Tests/Unit-Tests/CodeGeneratorContextTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
using System; | ||
using System.Linq; | ||
using MonoDroid.Generation; | ||
using NUnit.Framework; | ||
|
||
namespace generatortests | ||
{ | ||
[TestFixture] | ||
public class CodeGeneratorContextTests | ||
{ | ||
[Test] | ||
public void GetContextTypeMember () | ||
{ | ||
var klass = new TestClass ("Object", "java.code.MyClass"); | ||
|
||
klass.AddMethod (SupportTypeBuilder.CreateMethod (klass, "Echo", new CodeGenerationOptions (), "uint", false, false, new Parameter ("value", "uint", "uint", false))); | ||
klass.AddField (new TestField ("string", "Foo")); | ||
|
||
var context = new CodeGeneratorContext (); | ||
context.ContextTypes.Push (klass); | ||
|
||
Assert.AreEqual ("java.code.MyClass", context.GetContextTypeMember ()); | ||
|
||
context.ContextMethod = klass.Methods.Single (); | ||
|
||
Assert.AreEqual ("java.code.MyClass.Echo (uint)", context.GetContextTypeMember ()); | ||
|
||
context.ContextMethod = null; | ||
context.ContextField = klass.Fields.Single (); | ||
|
||
Assert.AreEqual ("java.code.MyClass.Foo", context.GetContextTypeMember ()); | ||
|
||
context.ContextMethod = klass.Methods.Single (); | ||
context.ContextField = null; | ||
context.ContextTypes.Clear (); | ||
|
||
Assert.AreEqual ("Echo (uint)", context.GetContextTypeMember ()); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters