fix(semver): remove min electron version checking

jonluca · May 8, 2023 · 6b67f26 · 6b67f26
1 parent 76cee8a
commit 6b67f26
Show file tree

Hide file tree

Showing 4 changed files with 145 additions and 150 deletions.
diff --git a/package.json b/package.json
@@ -35,11 +35,9 @@
   },
   "dependencies": {
     "@types/jszip": "^3.4.1",
-    "@types/semver": "^7.3.13",
     "fs-jetpack": "^5.1.0",
     "jszip": "^3.10.1",
-    "rimraf": "^5.0.0",
-    "semver": "^7.5.0"
+    "rimraf": "^5.0.0"
   },
   "devDependencies": {
     "@types/electron": "^1.6.10",

diff --git a/src/extensions.ts b/src/extensions.ts
@@ -2,46 +2,37 @@ import type { ExtensionReference } from "./index";
 
 export const EMBER_INSPECTOR: ExtensionReference = {
   id: "bmdblncegkenkacieihfhpjfppoconhi",
-  electron: ">=1.2.1",
   version: "4.9.1",
 };
 export const REACT_DEVELOPER_TOOLS: ExtensionReference = {
   id: "fmkadmapgofadopljbjfkapdkoienihi",
-  electron: ">=1.2.1",
   version: "4.27.3",
 };
 export const BACKBONE_DEBUGGER: ExtensionReference = {
   id: "bhljhndlimiafopmmhjlgfpnnchjjbhd",
-  electron: ">=1.2.1",
   version: "0.4.1",
 };
 export const JQUERY_DEBUGGER: ExtensionReference = {
   id: "dbhhnnnpaeobfddmlalhnehgclcmjimi",
-  electron: ">=1.2.1",
   version: "0.1.3.2",
 };
 export const ANGULAR_DEVTOOLS: ExtensionReference = {
   id: "ienfalfjdbdpebioblfackkekamfmbnh",
-  electron: ">=1.2.1",
   version: "1.0.7",
 };
 export const VUEJS_DEVTOOLS: ExtensionReference = {
   id: "nhdogjmejiglipccpnnnanhbledajbpd",
-  electron: ">=1.2.1",
   version: "6.5.0",
 };
 export const REDUX_DEVTOOLS: ExtensionReference = {
   id: "lmhkpmbekcpmknklioeibfkpmmfibljd",
-  electron: ">=1.2.1",
   version: "3.0.19",
 };
 export const APOLLO_DEVELOPER_TOOLS: ExtensionReference = {
   id: "jdkknkkbebbapilgoeccciglkfbmbnfm",
-  electron: ">=1.2.1",
   version: "4.1.4",
 };
 export const MOBX_DEVTOOLS: ExtensionReference = {
   id: "pfgnfdagidkfgccljigdamigbcnndkod",
-  electron: ">=1.2.1",
   version: "0.9.26",
 };
diff --git a/src/index.ts b/src/index.ts
@@ -1,6 +1,5 @@
 import type { LoadExtensionOptions } from "electron";
 import { session } from "electron";
-import * as semver from "semver";
 import * as path from "path";
 import * as rimraf from "rimraf";
 import unzip from "./unzip";
@@ -68,10 +67,6 @@ export interface ExtensionReference {
    * Extension ID
    */
   id: string;
-  /**
-   * Range of electron versions this extension is supported by
-   */
-  electron: string;
   /**
    * Working version
    */
@@ -120,13 +115,6 @@ export const installExtension = async (
   let chromeStoreID: string;
   if (typeof extensionReference === "object" && extensionReference.id) {
     chromeStoreID = extensionReference.id;
-    const electronVersion = process.versions.electron.split("-")[0];
-    const coercedVersion = semver.coerce(electronVersion)!;
-    if (!semver.satisfies(coercedVersion, extensionReference.electron)) {
-      throw new Error(
-        `Version of Electron: ${electronVersion} does not match required range ${extensionReference.electron} for extension ${chromeStoreID}`,
-      );
-    }
   } else if (typeof extensionReference === "string") {
     chromeStoreID = extensionReference;
   } else {