Ignore newline semicolon for css files. #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
index.js
Outdated
| @@ -75,6 +77,9 @@ function addAssetsToStream(paths, files) { | |||
|
|
|||
| // option for newLine in gulp-concat | |||
| if (options.hasOwnProperty('newLine')) { | |||
| if (options.newLine === ';' && type === 'css') { | |||
| options.newLine = ''; | |||
There was a problem hiding this comment.
Suggest set options.newLine to null, as 'gulp-concat' checks type for string and ignores anything else.
jonkemp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix to #241 and #248.
This would
only apply the newline option when concatenating js files and leave css files aloneignore newline semicolon for css files. It turns out css files do not need this option. If they do, then we can come up with another solution. I want to make sure that is needed first though.