Move go.mod replaced forks to publicly accessible package. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's difficult to reference packages externally because of the replace directive referencing an internal package: ``` $ go install github.com/jonjohnsonjr/dagdotdev/cmd/oci /Users/wlynch/go/pkg/mod/github.com/jonjohnsonjr/dagdotdev@v0.0.7-0.20240821193425-772575746fe1/internal/soci/indexer.go:25:22: undefined: zstd.Checkpoint /Users/wlynch/go/pkg/mod/github.com/jonjohnsonjr/dagdotdev@v0.0.7-0.20240821193425-772575746fe1/internal/soci/indexer.go:95:32: undefined: zstd.Checkpoint /Users/wlynch/go/pkg/mod/github.com/jonjohnsonjr/dagdotdev@v0.0.7-0.20240821193425-772575746fe1/internal/soci/indexer.go:96:38: undefined: zstd.WithCheckpoints /Users/wlynch/go/pkg/mod/github.com/jonjohnsonjr/dagdotdev@v0.0.7-0.20240821193425-772575746fe1/internal/soci/indexer.go:100:10: cannot use zr (variable of type *"github.com/klauspost/compress/zstd".Decoder) as checkpointReader value in assignment: *"github.com/klauspost/compress/zstd".Decoder does not implement checkpointReader (missing method CompressedCount) ``` This moves the replaced packages from internal -> pkg so that downstream modules and replicate the same replace behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's difficult to reference packages externally because of the replace directive referencing an internal package:
This moves the replaced packages from internal -> pkg so that downstream modules can replicate the same replace behavior.