-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add errata print01-ch07-lst2-open-paren #32
Add errata print01-ch07-lst2-open-paren #32
Conversation
Good catch! I'd actually like the fix to be the the other way though — we should change the closing paren to a brace |
Thanks, I had no idea! I will push a commit to use a brace instead. |
I believe the Also, would you mind updating the file name? |
No problem updating the filename. Regarding the semicolon, I got an error when trying it with a brace + semicolon during my own testing. Would you be able to double-check? If you insist I can remove it. Here is the error I got:
Here is my code if it helps: https://gist.github.com/nmarley/0831cf27ca12ce7e6b1234af8162e94e |
It seems like |
Huh, no, looks like you're spot on. From the reference, macro invocations with a
This is also supported by rust-lang/rust#34418. So let's get rid of the |
This reverts commit 14f12b9.
Oh nice! Thanks for letting me know where to find this information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.