Fix a bunch of UBs #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Thank you! Would you mind merging from |
- Creating a reference then using it to read more bytes than its type is UB in Stacked Borrows - Converting a shared reference to a reference to `UnsafeCell` is UB in Stacked Borrows, writing to it is UB in Tree Borrows too - Writing normally (`*p = ...`, not `std::ptr::write(p, ...)` to an uninitialized pointer is maybe UB because it drops the old data Fix all of those. I didn't do a full audit and didn't check the orderings, but the tests pass Miri now.
|
Done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
|
Releasing in #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnsafeCellis UB in Stacked Borrows, writing to it is UB in Tree Borrows too*p = ..., notstd::ptr::write(p, ...)to an uninitialized pointer is maybe UB because it drops the old dataFix all of those. I didn't do a full audit and didn't check the orderings, but the tests pass Miri now.