loadOrganizationLimits System.OrgLimits optimisation #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongpie
added
optimization
Layer: Log Management
|
@ngreardSF this is great! Thanks for logging #801 & submitting this PR. The pipeline doesn't automatically run for forked PRs, so I'm working on manually creating a new package version with your changes. I'm hoping to have this released either today or tomorrow 🥳 |
…me to include 'serializable' to provide a little more context on why there is a custom class for org limits These were existing names (that I wrote), and having not looked at this code in a while, it took me a moment to remember why the custom class was needed. A small comment + more verbose names should help make it clear why it's needed.
jongpie
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
@ngreardSF your changes look great! I added a few commits related to packaging + I renamed some variables & classes in LogHandler (mostly existing variables & classes that I had named), and I think this is ready to go!
I'll merge & release this later today.
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #801 - review loadOrganizationLimits to minimise CPU usage