Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring '23 release (API v57.0) - v4.10.0 #465

Merged
merged 19 commits into from
Apr 5, 2023

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Mar 16, 2023

Core Package Changes

Enhancements

Bugfixes

Code Cleanup

  • Bumped all metadata to API v57.0 (Summer '23 release)
  • Moved the private constant LogEntryEventBuilder.ORGANIZATION_API_VERSION to Logger.ORGANIZATION_API_VERSION so Logger can dynamically include the API version when saving with the save method Logger.SaveMethod.REST
  • Finally removed the last @future method in the codebase, LogEntryEventHandler.setStatusApiDetails() (used to call the Salesforce Status API), and replaced it with a private queueable class LogEntryEventHandler.StatusApiCalloutQueueable

Documentation

  • Added sfdx commands in README.md so everyone can easily copy & paste the recommended commands to install Nebula Logger's unlocked & managed core packages. This is manually done for now - in a future PR, I'll add automation to handle updating the package version IDs (04t) in README.md any time a new package version is generated

jongpie added 3 commits March 15, 2023 12:20
…vel sfdx-project.json, updated pwsh and npm scripts to use new syntax & parameters for sfdx commands
…ION to Logger.ORGANIZATION_API_VERSION so Logger can dynamically include the API version for REST callouts
@jongpie jongpie force-pushed the feature/spring-23-api-version-upgrade branch from a4451dd to 262c75a Compare March 16, 2023 16:22
…the Salesforce Status API), and replaced it with a private queueable class
@jongpie jongpie force-pushed the feature/spring-23-api-version-upgrade branch from 262c75a to 52a117e Compare March 16, 2023 16:40
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org March 16, 2023 16:44 — with GitHub Actions Failure
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org March 16, 2023 17:17 — with GitHub Actions Failure
…lag in build.yml when using the namespace is not needed
@jongpie jongpie force-pushed the feature/spring-23-api-version-upgrade branch from 8f06f43 to b9e8954 Compare March 16, 2023 17:19
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org March 16, 2023 17:22 — with GitHub Actions Failure
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org March 16, 2023 17:57 — with GitHub Actions Failure
@jongpie jongpie temporarily deployed to Base Scratch Org March 16, 2023 17:57 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the feature/spring-23-api-version-upgrade branch from 94fec4d to e3c885d Compare March 16, 2023 19:41
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org March 16, 2023 19:46 — with GitHub Actions Failure
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org March 16, 2023 20:33 — with GitHub Actions Failure
@jongpie jongpie temporarily deployed to Base Scratch Org March 16, 2023 20:33 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the feature/spring-23-api-version-upgrade branch from 8544b58 to 31c4750 Compare March 16, 2023 20:53
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org March 16, 2023 20:57 — with GitHub Actions Failure
@jongpie jongpie temporarily deployed to Base Scratch Org March 16, 2023 20:57 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the feature/spring-23-api-version-upgrade branch from 31c4750 to f99da4e Compare March 16, 2023 21:12
@jongpie jongpie temporarily deployed to Base Scratch Org March 16, 2023 21:16 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org March 16, 2023 21:16 — with GitHub Actions Inactive
* Regenerated apex docs (there were a couple of pages that were out of date)

* Added a PMD rule exclusion for `EagerlyLoadedDescribeSObjectResult` until some npm dependencies & scripts have been upgraded
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org March 31, 2023 06:04 — with GitHub Actions Failure
@jongpie jongpie temporarily deployed to Base Scratch Org March 31, 2023 06:04 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org March 31, 2023 06:14 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org March 31, 2023 06:14 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org March 31, 2023 06:28 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org March 31, 2023 15:28 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org March 31, 2023 15:28 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org March 31, 2023 15:28 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org March 31, 2023 15:28 — with GitHub Actions Inactive
@jongpie jongpie marked this pull request as ready for review March 31, 2023 15:32
@jongpie jongpie added Type: Bug Something isn't working Type: Enhancement New feature or request documentation Salesforce Feature: Reporting Anything related to reports, dashboards, and the underlying data model Logging Source: Apex Items related to using Logger within Apex Package Type: Managed Package Issues and enhancements that specifically apply to the managed package Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine Package Type: Unlocked Package Issues and enhancements that specifically apply to the unlocked package labels Mar 31, 2023
actions-user and others added 2 commits March 31, 2023 15:40
…dded managed package version ID, and updated an sfdx auth command in build.yml
@jongpie jongpie force-pushed the feature/spring-23-api-version-upgrade branch from 992f674 to 0b682c3 Compare March 31, 2023 15:56
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 99.25% and project coverage change: +0.05 🎉

Comparison is base (46ddff1) 94.99% compared to head (76aacf2) 95.04%.

❗ Current head 76aacf2 differs from pull request most recent head 195843f. Consider uploading reports for the commit 195843f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   94.99%   95.04%   +0.05%     
==========================================
  Files          56       56              
  Lines        5676     5754      +78     
  Branches      114      113       -1     
==========================================
+ Hits         5392     5469      +77     
- Misses        279      280       +1     
  Partials        5        5              
Flag Coverage Δ
Apex 95.48% <99.22%> (+0.05%) ⬆️
LWC 92.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/logger-engine/classes/LogEntryEventBuilder.cls 94.57% <94.11%> (-0.12%) ⬇️
...in/log-management/classes/LogEntryEventHandler.cls 90.43% <100.00%> (+0.04%) ⬆️
...g-management/classes/LogManagementDataSelector.cls 100.00% <100.00%> (ø)
...ain/log-management/classes/LogViewerController.cls 100.00% <100.00%> (ø)
...ore/main/log-management/lwc/logViewer/logViewer.js 88.60% <100.00%> (+0.14%) ⬆️
...-logger/core/main/logger-engine/classes/Logger.cls 96.04% <100.00%> (+0.22%) ⬆️
...s/slack/plugin/slack/classes/SlackLoggerPlugin.cls 85.02% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jongpie jongpie merged commit c9c4b5d into main Apr 5, 2023
@jongpie jongpie deleted the feature/spring-23-api-version-upgrade branch April 5, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine Logging Source: Apex Items related to using Logger within Apex Package Type: Managed Package Issues and enhancements that specifically apply to the managed package Package Type: Unlocked Package Issues and enhancements that specifically apply to the unlocked package Salesforce Feature: Reporting Anything related to reports, dashboards, and the underlying data model Type: Bug Something isn't working Type: Enhancement New feature or request
Projects
None yet
3 participants