Fixed upsert logic for Log__c so it doesn't assume that there is only 1 transaction ID involved #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 1 transaction ID involved It's hard to reproduce the scenario consistently, but it seems like in practice, 1 transaction of AFTER_INSERT on LogEntryEvent__e can sometimes have records with different transaction IDs. This seems to happen with some logging in batch jobs, so better to bulkify the upsert
Since all branches currently run on push, the PR push causes duplicate validations
TRANSACTION_ID_TO_LOG holds all logs that have been upserted in the current transaction, logsToUpsert holds just the logs that need to be upserted
jongpie
added
Layer: Log Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to reproduce the scenario consistently, but it seems like in practice, 1 transaction of AFTER_INSERT on LogEntryEvent__e can sometimes have records with different transaction IDs. This seems to happen with some logging in batch jobs, but the existing code has an incorrect assumption that all of the
LogEntryEvent__erecords are tied to the same transaction ID.I've updated the logic in
LogEntryEventHandlerto upsert aList<Log__c>(1 record per transaction ID) instead of just a singleLog__crecord.