Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inaccessible methods in namespaced package #12

Merged
merged 5 commits into from
Mar 6, 2023

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Feb 27, 2023

  • Fixed Classes are not accessible in the namespace package version #11 by updating CacheManager to make several items global instead of public
    • CacheManager.Cacheable interface
    • Cacheable getOrganizationCache() static method
    • Cacheable getOrganizationCache(CacheConfiguration__mdt configuration) static method
    • Cacheable getSessionCache() static method
    • Cacheable getSessionCache(CacheConfiguration__mdt configuration) static method
    • Cacheable getTransactionCache() static method
  • Added pipeline for GitHub Actions

@jongpie jongpie added bug Something isn't working namespaced package Issue or enhancement for the namespaced package labels Feb 27, 2023
@jongpie jongpie changed the title Fixed inaccessible methods in namedpaced package Fixed inaccessible methods in namespaced package Feb 27, 2023
@jongpie jongpie force-pushed the bugfix/inaccesible-methods-in-namespaced-package branch 2 times, most recently from f1566eb to 9c3ef74 Compare February 27, 2023 22:26
@jongpie jongpie temporarily deployed to Base Scratch Org February 27, 2023 22:28 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org February 27, 2023 22:28 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@104a41c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage        ?   97.28%           
=======================================
  Files           ?        1           
  Lines           ?      221           
  Branches        ?        0           
=======================================
  Hits            ?      215           
  Misses          ?        6           
  Partials        ?        0           
Flag Coverage Δ
Apex 97.28% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jongpie jongpie temporarily deployed to Platform Cache Scratch Org February 27, 2023 22:39 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org February 27, 2023 22:39 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the bugfix/inaccesible-methods-in-namespaced-package branch from 9c3ef74 to 71b5b98 Compare February 27, 2023 22:50
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org February 27, 2023 22:51 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org February 27, 2023 22:51 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the bugfix/inaccesible-methods-in-namespaced-package branch from ad24aec to 07d140d Compare March 6, 2023 15:51
@jongpie jongpie temporarily deployed to Base Scratch Org March 6, 2023 15:53 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org March 6, 2023 15:53 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the bugfix/inaccesible-methods-in-namespaced-package branch from 07d140d to 9d7c728 Compare March 6, 2023 16:49
@jongpie jongpie had a problem deploying to Platform Cache Scratch Org March 6, 2023 16:51 — with GitHub Actions Failure
@jongpie jongpie temporarily deployed to Base Scratch Org March 6, 2023 16:51 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the bugfix/inaccesible-methods-in-namespaced-package branch from 9d7c728 to 29a42f8 Compare March 6, 2023 16:57
@jongpie jongpie temporarily deployed to Base Scratch Org March 6, 2023 16:58 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org March 6, 2023 16:58 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the bugfix/inaccesible-methods-in-namespaced-package branch from 29a42f8 to f887cd3 Compare March 6, 2023 17:13
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org March 6, 2023 17:14 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org March 6, 2023 17:14 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the bugfix/inaccesible-methods-in-namespaced-package branch from f887cd3 to aaeb1dc Compare March 6, 2023 17:28
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org March 6, 2023 17:29 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org March 6, 2023 17:29 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the bugfix/inaccesible-methods-in-namespaced-package branch from aaeb1dc to b40f8d8 Compare March 6, 2023 18:21
@jongpie jongpie temporarily deployed to Base Scratch Org March 6, 2023 18:22 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org March 6, 2023 18:22 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org March 6, 2023 18:48 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org March 6, 2023 18:48 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the bugfix/inaccesible-methods-in-namespaced-package branch from fbe540d to fac9d5b Compare March 6, 2023 18:58
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org March 6, 2023 18:59 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org March 6, 2023 18:59 — with GitHub Actions Inactive
…cheable interface, and several public static methods
@jongpie jongpie force-pushed the bugfix/inaccesible-methods-in-namespaced-package branch from fac9d5b to e8934c0 Compare March 6, 2023 19:15
@jongpie jongpie temporarily deployed to Base Scratch Org March 6, 2023 19:16 — with GitHub Actions Inactive
@jongpie jongpie had a problem deploying to Platform Cache Scratch Org March 6, 2023 19:16 — with GitHub Actions Failure
@jongpie jongpie temporarily deployed to Base Scratch Org March 6, 2023 19:22 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org March 6, 2023 19:22 — with GitHub Actions Inactive
@jongpie jongpie marked this pull request as ready for review March 6, 2023 19:38
@jongpie jongpie merged commit 3dbf694 into main Mar 6, 2023
@jongpie jongpie deleted the bugfix/inaccesible-methods-in-namespaced-package branch March 6, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working namespaced package Issue or enhancement for the namespaced package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classes are not accessible in the namespace package version
2 participants