Coerce booleans and integers to other types #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since UCI doesn't really have types anywhere, we have to be very careful about how we parse things. If an option has a value of `"1"`, this could be a boolean, integer, or string; depending on the config it's a part of. Frankly, this is an incredibly bad representation. And it feels like the sort of thing where a language is not designed, but extended over years without taking a step back and removing these awkward cases. We add support for coercing the different types that we can at least identify as possibly being something else. We almost surely are missing some cases here. But, we'll deal with that when they arise. For now, we at least can coerce some booleans and integers to other types. Hopefully, this catches most of the cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since UCI doesn't really have types anywhere, we have to be very careful
about how we parse things. If an option has a value of
"1", this couldbe a boolean, integer, or string; depending on the config it's a part
of. Frankly, this is an incredibly bad representation. And it feels like
the sort of thing where a language is not designed, but extended over
years without taking a step back and removing these awkward cases.
We add support for coercing the different types that we can at least
identify as possibly being something else. We almost surely are missing
some cases here. But, we'll deal with that when they arise. For now, we
at least can coerce some booleans and integers to other types.
Hopefully, this catches most of the cases.