Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a system for tooltips #237

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

NancokPS2
Copy link
Contributor

@NancokPS2 NancokPS2 commented Feb 1, 2024

It is surprisingly difficult to find the position of text without direct access to TextSever RIDs (i tried for 3 days). So this will probably get reworked with Godot 4.3 which adds a method to do it for you.

This tooltip is a Node2D that when added to any Control node, will automatically display a tooltip in the direction opposite to the closest edge of the screen (can be forced to be a set direction) with text set on the Tooltip node.
It will use the parent's theme if it has any and no theme was defined on the tooltip yet.
It also supports "sub tooltips" which cause yet another tooltip to spring from the original when a keyword is hovered with the mouse, explaining in further detail said keyword.
Sub tooltips have been delayed until Godot 4.3

Tooltips can be "pinned" which prevents them from moving or dissapearing by pressing the middle mouse button by default.

Added tooltips to some stats in the stats menu, the shop UI and the shortcuts at the top left of the screen.

TODO:

  • Add tooltips to some UI nodes
  • Consider a component version that augments existing Labels

@NancokPS2 NancokPS2 marked this pull request as ready for review February 11, 2024 00:22
@NancokPS2 NancokPS2 changed the title Adds a system for interactive tooltips Adds a system for ~interactive~ tooltips Feb 11, 2024
@NancokPS2 NancokPS2 changed the title Adds a system for ~interactive~ tooltips Adds a system for tooltips Feb 11, 2024
var closest_dir_to_border: PopupDirections
var smallest_value: float = INF

print(direction_dist_dict)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This print should probably be removed

@jonathaneeckhout
Copy link
Owner

jonathaneeckhout commented Feb 12, 2024

Testing:

  • Tooltips are nicely shown

Issues:

  • When testing I can't open the shops of the npc's anymore

@NancokPS2 NancokPS2 marked this pull request as draft February 17, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants