Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to composition #127

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Move to composition #127

merged 1 commit into from
Oct 31, 2023

Conversation

jonathaneeckhout
Copy link
Owner

@jonathaneeckhout jonathaneeckhout commented Oct 27, 2023 •
edited
Loading

This PR introduces the composition system instead of the classed based system.

The goal is to make the code more readable and maintainable.

Current known limitations:

  • the loop animation will continue after the die animation
  • collisions are not correct when dead
  • ...

@jonathaneeckhout jonathaneeckhout marked this pull request as draft October 27, 2023 13:03
@jonathaneeckhout jonathaneeckhout marked this pull request as ready for review October 31, 2023 21:20
@jonathaneeckhout jonathaneeckhout merged commit 6ba98b9 into main Oct 31, 2023
3 checks passed
@jonathaneeckhout jonathaneeckhout deleted the dev_test_composition branch October 31, 2023 21:23
@jonathaneeckhout jonathaneeckhout changed the title Draft: move to composition Move to composition Oct 31, 2023
@jonathaneeckhout jonathaneeckhout linked an issue Oct 31, 2023 that may be closed by this pull request
Dev Task: use more composition. #123
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev Task: use more composition.
1 participant
@jonathaneeckhout