-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chinese(zh-CN) support #937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but translated files must be added to Transifex, it is from there translations are pulled.
It may be possible to push translations as well.
Are both zh and zh-rCN needed?
@@ -57,6 +57,7 @@ | |||
<item>Suomi</item> | |||
<item>Svenska</item> | |||
<item>Türkçe</item> | |||
<item>简体中文</item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is intended to be in "alphabetic" sort order with local names. Is "Chinese" supposed to be sorted last like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine.
app/res/values/cues.xml
Outdated
@@ -16,6 +16,7 @@ | |||
~ along with this program. If not, see <http://www.gnu.org/licenses/>.--> | |||
<string name="cue_activity">activity</string> | |||
<string name="cue_interval">interval</string> | |||
<string name="Cue_intervall_m">interval</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this string?
(may be an old string)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be an old string, I translated it last year. I use RunnerUp everyday, so I thinks maybe there's someone would like it.
There're some other zh format, like zh-TW, zh-HK, which use traditional Chinese. Maybe someone could translate it.
The Chinese translation in Transifex is empty, so the translations can be pushed (I have not used that function though). |
What to keep of zh or zh-CN? using zh, those that has traditional get simplified instead of English which is probably a good thing This can be changed (as is done for sv-SE in Transifex and sv in RU). So unless you have other suggestions @chenzaichun I will do the following:
|
@gerhardol sure, I think keep zh-CN is acceptable right now. I'll add translation for traditional chinese later. Thanls. |
Use zh-CN on Transifex, map to 'zh' in the app for now
Translations pushed: https://www.transifex.com/runner-up/runner-up-android/language/zh_CN/ There are a few new strings to translate I pushed a cleaned up commit to https://github.com/gerhardol/runnerup/tree/chenzaichun/chinese-support |
@gerhardol I had added missing translation in transifex, but I don't know what can I do next. Could you please help? Should I add the missing translation to the xml and push to the PR again? |
Register in transifex and up date there |
already updated in transifex. :) |
Can you make sure I can push to the branch (allow maintainers), then I will pull from Transifex to my squashed branch, push to this branch and merge |
9892244
to
e1b85e0
Compare
@gerhardol I reset the branch to the commit you squashed, and you could merge and push to this branch. Thanks. |
Thanks I did a fixup to Transifex zh for two arrays, pulled the updates in another PR (also merged) |
Thanks. :) |
Add simplified chinese translation.