-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endurain file upload support #1193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only browsed the code, did not react to anything. It is basically EndurainSynch that need to be reviewed.
When adding an account with dummy url/user, it was still added as an active account, should only be added at success.
Not sure I want to run this myself, any user that can join?
I could provide you an endurain test instance if you don't want to spin it up. |
Maybe. But I would prefer that someone that will use this functionality also would test take it for a spin, to make sure it works as expected. Dont misunderstand me: It is great that features are added, this open source. But if am a very sporadic user, I can only say if it seems to work or not. A regular user could have usage comments. |
Totally agree 👍 would also like to see someone who would like to use/test it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please autoformat EndurainSynchronizer.java in AS
Someone else to test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brief usage myself, works fine for me.
Squash merge?
I could squash the commits sure 😃 |
I can do that but then I set the commit message. |
done 👍 |
This pull requests adds a new Synchronizer for the self-hostable endurain software.
This PR solves #1185
I would love to add some unit tests but I can't find some examples where Synchronizers are tested.
To test this implementation I've keeped some commits to use it against a http endurain instance for example with an emulator and docker compose locally.
I used following config of endurain locally:
If you have further questions how to test that with endurain I could provide more information.