Make the :suspicious-test linter omittable
#371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
commented
Apr 27, 2021
| {:linter :suspicious-test | ||
| :if-inside-macroexpansion-of #{'clojure.test/are} | ||
| ;; only omit the warning if :suspicious-test failed due to a `true` value: | ||
| :qualifier true |
There was a problem hiding this comment.
The concept of a :qualifier is new.
With it we can be more confident that we aren't muting untargeted instances of a given warning.
...this :qualifier value so far only is used in the :suspicious-test. Other linters could eventually benefit from it, would have to give it a look
slipset
approved these changes
Apr 28, 2021
2 tasks
Supports a specific `clojure.test/are` pattern.
|
Ready again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports a specific
clojure.test/arepattern, as shown in the included tests....This pattern tends to fail better (else a test failure would show up twice), which is why it's a good idea for Eastwood to support it.