Fix false positive re: protocols in unused-namespaces linter. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thoughts? |
|
Sorry for not responding sooner. I have been pretty busy at the office the last several weeks, and haven't had much time to look at Eastwood during that time. Hopefully I'll get a chance to look at it during the next month. |
|
Could you possibly give a look some time soon? |
|
any update on this merge? would love to re-enable unused-namespace checks |
|
Thanks for the patch, with unit test cases included, woohoo! I tested it out on about 80 Clojure projects, and it eliminated at least 5 incorrect unused-namespace warnings. There are definitely still some incorrect unused-namespace warnings that remain, but eliminating those can wait for a future enhancement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #162. Let me know what you think.