Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint against assoc! performed as a side-effect #441

Closed
vemv opened this issue Sep 13, 2022 · 0 comments · Fixed by #442
Closed

Lint against assoc! performed as a side-effect #441

vemv opened this issue Sep 13, 2022 · 0 comments · Fixed by #442

Comments

@vemv
Copy link
Collaborator

vemv commented Sep 13, 2022

The "contract" for transients is that they have to returned as a value.

Performing assoc! as a side-effect is therefore error-prone.

It should be easy to tweak Eastwood config to ban this.

Full discussion: https://clojurians.slack.com/archives/C03S1KBA2/p1663107357949519
vemv added a commit that referenced this issue Sep 13, 2022
@vemv
Lint against incorrect transient usage
62592f8 
Closes #441
@vemv vemv mentioned this issue Sep 13, 2022
Merged
vemv added a commit that referenced this issue Sep 13, 2022
@vemv
Lint against incorrect transient usage
b3484d6 
Closes #441
@vemv vemv closed this as completed in #442 Sep 14, 2022
vemv added a commit that referenced this issue Sep 14, 2022
@vemv
Lint against incorrect transient usage (#442)
d289d06 
* Lint against incorrect transient usage

Closes #441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lint against incorrect transient usage jonase/eastwood
1 participant
@vemv