[Fix #386] Support (while true) pattern (#391)

Closes #386

cases/testcases/while_true/green.clj

@@ -0,0 +1,5 @@
+(ns testcases.while-true.green)
+
+(defn foo []
+  (while true
+    (println 1)))

cases/testcases/while_true/red.clj

@@ -0,0 +1,5 @@
+(ns testcases.while-true.red)
+
+(defn foo []
+  (while 1
+    (println 1)))

changes.md

@@ -6,6 +6,8 @@
 
 * Support `(is false)` pattern
   * Closes https://github.com/jonase/eastwood/issues/384
+* Support `(while true)` pattern
+  * Closes https://github.com/jonase/eastwood/issues/386
 
 #### Bugfixes
 

resource/eastwood/config/clojure.clj

@@ -77,6 +77,13 @@
    :within-depth 2
    :reason "Allow as-> to have constant tests without warning"})
 
+(disable-warning
+  {:linter :constant-test
+   :if-inside-macroexpansion-of #{'clojure.core/while}
+   :within-depth 3
+   :qualifier true
+   :reason "Allow `(while true)` idiom"})
+
 (disable-warning
   {:linter :wrong-arity
    :function-symbol 'clojure.core/eduction

test/eastwood/lint_test.clj

@@ -261,6 +261,17 @@ relative to a specific macroexpansion"
       #{'testcases.let.green} {:some-warnings false}
       #{'testcases.let.red}   {:some-warnings true})))
 
+(deftest while-true-test
+  (testing "The `(while true)` idiom is supported"
+    (are [input expected] (testing input
+                            (is (= (assoc expected :some-errors false)
+                                   (-> eastwood.lint/default-opts
+                                       (assoc :namespaces input)
+                                       (eastwood.lint/eastwood))))
+                            true)
+      #{'testcases.while-true.green} {:some-warnings false}
+      #{'testcases.while-true.red}   {:some-warnings true})))
+
 (deftest is-false-test
   (testing "The `(is false)` idiom is supported"
     (are [input expected] (testing input