Fix false positive for clojure.spec.alpha/every

Fixes #435
jonase · Jun 17, 2022 · 177080e · 177080e
1 parent 4b84b11
commit 177080e
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 2 deletions.
diff --git a/cases/testcases/constant_test/spec_every/green.clj b/cases/testcases/constant_test/spec_every/green.clj
@@ -0,0 +1,21 @@
+(ns testcases.constant-test.spec-every.green
+  (:require
+   [clojure.spec.gen.alpha :as gen]
+   [clojure.test :refer [are deftest is join-fixtures testing use-fixtures]]
+   [clojure.spec.alpha :as spec]))
+
+;; https://github.com/jonase/eastwood/issues/435
+(spec/def ::some-spec (spec/map-of
+                       (spec/spec string?
+                                  :gen (fn [] (gen/fmap
+                                               #(apply str %)
+                                               (gen/vector
+                                                gen/char-alpha
+                                                5 20))))
+                       (spec/coll-of
+                        (spec/tuple ::source ::sub-type)
+                        :into #{}
+                        :min-count 2
+                        :gen-max 7)
+                       :min-count 2
+                       :gen-max   8))
diff --git a/changes.md b/changes.md
@@ -1,3 +1,10 @@
+## Changes from 1.2.3 to
+
+#### Bugfixes
+
+* Fix false positive for `clojure.spec.alpha/every`.
+  * Closes https://github.com/jonase/eastwood/issues/435
+
 ## Changes from 1.2.2 to 1.2.3
 
 #### Bugfixes

diff --git a/resource/eastwood/config/clojure.clj b/resource/eastwood/config/clojure.clj
@@ -52,7 +52,10 @@
 (disable-warning
  {:linter :constant-test
   :for-macro 'clojure.core/or
-  :if-inside-macroexpansion-of #{'clojure.spec/coll-of 'clojure.spec.alpha/coll-of}
+  :if-inside-macroexpansion-of #{'clojure.spec/coll-of
+                                 'clojure.spec.alpha/coll-of
+                                 'clojure.spec/every
+                                 'clojure.spec.alpha/every}
   :within-depth 8
   :reason "clojure.spec's `coll-of` can contain `clojure.core/or` invocations with only one argument."})
 

diff --git a/test/eastwood/lint_test.clj b/test/eastwood/lint_test.clj
@@ -373,7 +373,16 @@ relative to a specific macroexpansion"
       ;; Suggested an improvement upstream here:
       ;; https://ask.clojure.org/index.php/10712/minor-performance-improvement-initial-values-known-compile
       #{'testcases.constant-test.some-thread-first.green} {:some-warnings false}
-      #{'testcases.constant-test.some-thread-last.green}  {:some-warnings false})))
+      #{'testcases.constant-test.some-thread-last.green}  {:some-warnings false}))
+
+  (testing "https://github.com/jonase/eastwood/issues/435"
+    (are [input expected] (testing input
+                            (is (= (assoc expected :some-errors false)
+                                   (-> sut/default-opts
+                                       (assoc :namespaces input)
+                                       (sut/eastwood))))
+                            true)
+      #{'testcases.constant-test.spec-every.green} {:some-warnings false})))
 
 (deftest unused-fn-args-test
   (testing "fn args within defmulti, see https://github.com/jonase/eastwood/issues/1"