Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages when serde_as is used wrongly or misleadingly #238

Merged
merged 4 commits into from
Jan 6, 2021
Merged

Improve error messages when serde_as is used wrongly or misleadingly #238

merged 4 commits into from
Jan 6, 2021

Conversation

jonasbb
Copy link
Owner

@jonasbb jonasbb commented Jan 5, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jan 5, 2021 •
edited
Loading

Codecov Report

Merging #238 (35bfdec) into master (b7a09f5) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   77.10%   77.03%   -0.08%     
==========================================
  Files          36       36              
  Lines        2101     2103       +2     
==========================================
  Hits         1620     1620              
- Misses        481      483       +2
Impacted Files Coverage Δ
serde_with_macros/src/lib.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a09f5...35bfdec. Read the comment docs.

@jonasbb
Copy link
Owner Author

jonasbb commented Jan 5, 2021

bors r+

bors bot added a commit that referenced this pull request Jan 5, 2021
@bors @jonasbb
Merge #238
977bdd4 
238: Improve error messages when serde_as is used wrongly or misleadingly r=jonasbb a=jonasbb



Co-authored-by: Jonas Bushart <jonas@bushart.org>
@bors
Copy link
Contributor

bors bot commented Jan 5, 2021

Build failed:

@jonasbb
Copy link
Owner Author

jonasbb commented Jan 6, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 6, 2021

Build succeeded:

@bors bors bot merged commit 0555004 into master Jan 6, 2021
@bors bors bot deleted the serde-as-error-messages branch January 6, 2021 09:07
@jonasbb jonasbb mentioned this pull request Jan 8, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonasbb