Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow pos->lineno to underflow in file search (#800) #801

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Don't allow pos->lineno to underflow in file search (#800) #801

merged 1 commit into from
Mar 19, 2018

Conversation

proski
Copy link
Contributor

@proski proski commented Mar 19, 2018

If no text is found in the file search, pos->lineno would become (unsigned long)-1 which would lead to invalid memory access in file_finder_draw()

@jonas jonas merged commit f5d6b15 into jonas:master Mar 19, 2018
@jonas
Copy link
Owner

jonas commented Mar 19, 2018

Thanks

rolandwalker pushed a commit to rolandwalker/tig that referenced this pull request May 21, 2018
@proski @rolandwalker
Don't allow pos->lineno to underflow in file search (jonas#800) (jona…
f6dfb02 
…s#801)

Fixes jonas#800
@proski proski deleted the blame-file-search-fix branch April 5, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proski @jonas