Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust case of reldate letters acc. to ISO-8601 #759

Closed
wants to merge 1 commit into from

Conversation

plgruener
Copy link
Contributor

This commit fixes the wrong use of 'm' for month and 'M' for minute:
In ISO-8601, uppercase letters YYYY-MM-DD are used to denote year,month,week,day;
whereas lowercase letters hh:mm:ss are used for hour,minute,second.

This commit fixes the wrong use of 'm' for month and 'M' for minute:
In ISO-8601, uppercase letters YYYY-MM-DD are used to denote year,month,week,day;
whereas lowercase letters hh:mm:ss are used for hour,minute,second.
@jonas
Copy link
Owner

jonas commented Dec 14, 2017

Sorry, it's been a while. The test/main/date-test files needs to be updated. Do you want to take a stab at that?

@plgruener
Copy link
Contributor Author

Yeah, I'll try to do it during the holidays.
But please be aware, as written in #760 , that this change will probably break user's custom tigrcs which do a fancy date-setting.

@jonas
Copy link
Owner

jonas commented Dec 15, 2017

Custom date formats must use the format expected by strftime(3).
This PR only changes the way relative dates are displayed so no user configuration will be affected.

@jonas
Copy link
Owner

jonas commented Dec 15, 2017

When you run the date-test:

> make test/main/date-test
      TEST  test/main/date-test

You can see the output of the actual screen with the relative date in the file

test/tmp/main/date-test/relative-compact-date.screen

@jonas jonas closed this in c0df450 May 20, 2018
@jonas
Copy link
Owner

jonas commented May 20, 2018

Thanks, I fixed the test and merged.

rolandwalker pushed a commit to rolandwalker/tig that referenced this pull request May 21, 2018
This commit fixes the wrong use of 'm' for month and 'M' for minute:
In ISO-8601, uppercase letters YYYY-MM-DD are used to denote year,month,week,day;
whereas lowercase letters hh:mm:ss are used for hour,minute,second.

Closes jonas#759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants