Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tig diff view doesn't scroll using up and down keys, when in log view there's opened diff preview #802

Closed
GRiMe2D opened this issue Mar 19, 2018 · 0 comments
Closed

Tig diff view doesn't scroll using up and down keys, when in log view there's opened diff preview #802

GRiMe2D opened this issue Mar 19, 2018 · 0 comments

Comments

@GRiMe2D
Copy link

GRiMe2D commented Mar 19, 2018

Steps to reproduce:

  1. Launch tig
  2. Log is shown, on Enter shows diff preview on right, and preview can be scrolled with j or k which is right.
  3. Select some revision in log, and press d to open full diff window.
  4. Up and Down keys switch previous or next revisions

If you don't open diff preview in step 2, 4th step work properly, Up, Down scrolls diff window
@GRiMe2D GRiMe2D changed the title Tig diff view doesn't handle, when in log view there's opened diff preview Tig diff view doesn't handle up and down keys, when in log view there's opened diff preview Mar 19, 2018
@GRiMe2D GRiMe2D changed the title Tig diff view doesn't handle up and down keys, when in log view there's opened diff preview Tig diff view doesn't scroll using up and down keys, when in log view there's opened diff preview Mar 19, 2018
koutcher added a commit to koutcher/tig that referenced this issue May 27, 2018
@koutcher
Fix incorrect behaviour of up and down keys in diff view when opened …
dfff3f3 
…from diff preview

Fixes jonas#802
@koutcher koutcher mentioned this issue May 27, 2018
Merged
koutcher added a commit to koutcher/tig that referenced this issue May 28, 2018
@koutcher
Fix incorrect behaviour of up and down keys in diff view when opened …
1673bfd 
…from diff preview

Fixes jonas#802
@jonas jonas closed this as completed in 2272096 May 28, 2018
jonas added a commit that referenced this issue May 31, 2018
@jonas
Add tests for #836 and #802
ec021ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GRiMe2D