Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforced overlap between amplicon inserts in tiled mode #43

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

jonas-fuchs
Copy link
Owner

@jonas-fuchs jonas-fuchs commented Jan 29, 2025

  • enforce insert overlap in tiled mode. Previously amplicon overlaps were scored which could lead to overlapping of fw and rv primers of flanking amplicons. Now varVAMP considers overlaps between two primers of flanking amplicons to guarantee sequence overlaps even after primer trimming.
  • changed the consensus file names as this caused issues with galaxy tests in the previous version.
  • deleted header from primer bed files to ensure compatibility with other tools

@jonas-fuchs
Copy link
Owner Author

@wm75 This PR includes changes that previously caused issues with the galaxy tool. Could you have a quick look whether I missed something?

@jonas-fuchs jonas-fuchs added the enhancement New feature or request label Jan 29, 2025
@jonas-fuchs jonas-fuchs self-assigned this Jan 29, 2025
@jonas-fuchs jonas-fuchs merged commit eb298ad into master Feb 6, 2025
2 checks passed
@jonas-fuchs jonas-fuchs deleted the insert_overlap branch February 6, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant