Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Androidx upgrade #291

Merged
merged 3 commits into from
Jul 14, 2019
Merged

Androidx upgrade #291

merged 3 commits into from
Jul 14, 2019

Conversation

gla5001
Copy link

@gla5001 gla5001 commented Jan 24, 2019

AndroidX is the replacement for Google Support Libraries. Android P is the transition phase for this. The next version of Android is likely to support only AndroidX. This library fails on android builds that use the new compileSdkVersion. This PR makes the transition to AndroidX.

The only changes in this PR are namespaces, package names in import statements, and Gradle dependencies.

The changes in this PR were auto-generated by Android Studio using instructions from here.

@gla5001 gla5001 mentioned this pull request May 11, 2019
@ankitbansal25
Copy link

Hi,
I am using this library for downloading. But I am facing the same issue. When Can I expect these changes in master? If not, is it possible to push these changes into a separate say, androidx-master branch, from where I can fork the changes?

@jgreen01su
Copy link

@ankitbansal25 You can just do this.
npm i https://github.com/gla5001/rn-fetch-blob.git\#androidx-upgrade

@jgreen01su
Copy link

It seems like there's more steps to make modules forward/backward compatible. See @mikehardy 's explanation in the link below.
itinance/react-native-fs#691 (comment)

@Traviskn
Copy link

react-native 60 and above are now requiring android x. after merging this in the next rn-fetch-blob version will only support react-native 60 and above

@Traviskn Traviskn merged commit fb9e007 into joltup:master Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants