Adding error handling #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @earv1 ! Thanks for your contribution! I've added a comment and then we're good to go :) |
Prefix unused variables with underscores Co-Authored-By: Victor Oliveira Nascimento <376386+victorolinasc@users.noreply.github.com>
|
Fixed, thanks for the feedback! |
|
Sorry... left another one about phrasing it better. What do you think? |
Fix phrasing Co-Authored-By: Victor Oliveira Nascimento <376386+victorolinasc@users.noreply.github.com>
|
That does make a lot more sense. I committed it. |
|
It ended up duplicating the inspect Oo. |
|
Ah, I'm a bit of a noob when it comes to elixir. What tool are you using, maybe I can check on my side. |
Co-Authored-By: Victor Oliveira Nascimento <376386+victorolinasc@users.noreply.github.com>
victorolinasc
approved these changes
Apr 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find any contribution guides, but I thought a good as place as any is to just create a commit and see what happens.
I was running into an issue where I was providing an incorrect parameter for map_key_algorithm. But I kept getting an error saying that the algorithm wasn't supported.