Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the slug always be generated with ASCII characters #2104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Pandede
Copy link
Contributor

@Pandede Pandede commented Sep 17, 2024

What does this change

Compose the slug with Latin words only, regardless the assigned locale.

What was wrong

The slug may be empty if there is no Latin characters in the locale language, such as Japanese, Korean and Chinese.

How this fixes it

Compose the slug with Latin words only, regardless the assigned locale.

Fixes #2103

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slug() - returns an empty string in some locales
2 participants