Fix pydecimal
handling of positive
keyword
#2080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
pydecimal
now handlespositive
keyword as expectedrandom.Random
now takes in expected typeint
for parameterWhat was wrong
random.Random
no longer accepts any hashable object as param (link)How this fixes it
positive
is None by default (in which case sign assigning is random) or it has been explicitly passed a sTrue
/Flase
(handled inelse
block)Hashable
toint
Fixes #2051