fix: random sign when +ve is false #1953
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When using
print(f.pyfloat(positive=False))
, the number could be positive or negative.Now when positive is false, only negative numbers would be returned.
What was wrong
Both negative and positive being returned. The code also seemed to not be format by isort (or maybe something wrong on my end). I did run isort though.
How this fixes it
Removed randomly picking a sign if positive is false
Fixes #1928
Now this could be intended, if it was, maintainers, please let me know, I would love to implement the random sign functionality but that would require changing the function arguments and tests.
All the tests pass on python 3.11