Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fake automotive vin number function (#1879) #1884

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

cyanghsieh
Copy link
Contributor

What does this change

base on https://en.wikipedia.org/wiki/Vehicle_identification_number to create fake vin number data function.

What was wrong

new provider function

How this fixes it

Note: I'm not quite familiar with pytest module, therefore I'm not quite confident on creating a new auto test flow for this vin function. Please forgive me.

@themattmorris
Copy link
Contributor

This is cool! I am also interested in using this feature, so if needed, I'd be happy to collaborate on building the tests for the feature.

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need tests before I can merge this.

@cyanghsieh cyanghsieh requested a review from fcurella June 28, 2023 09:20
@themattmorris
Copy link
Contributor

Looks like @cyanghsieh beat me to it anyways...thanks!

The only thing I wonder if is test_vin should be outside of class _SimplyAutomotiveTestMixin. Looks like running as is will run the same exact test for every provider, as it does not depend on any attributes the same way that test_license_plate does. But I'm also not familiar with the overall test strategy of this repo, and maybe this is what it should do?

@fcurella
Copy link
Collaborator

fcurella commented Jul 7, 2023

The only thing I wonder if is test_vin should be outside of class _SimplyAutomotiveTestMixin. Looks like running as is will run the same exact test for every provider, as it does not depend on any attributes the same way that test_license_plate does. But I'm also not familiar with the overall test strategy of this repo, and maybe this is what it should do?

I think that's ok for now. But we should think of a way to mark methods as locale-independent.

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit d23efeb into joke2k:master Jul 7, 2023
29 checks passed
@fcurella fcurella mentioned this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants