add color for fa_IR #1059
Merged
add color for fa_IR #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add bank and credit_card providers. but need to change exp_date to Jalali datetime.
|
@abtinmo Could you add some test? |
|
Thank you! ✨ |
IlfirinPL
pushed a commit
to IlfirinPL/faker
that referenced
this pull request
Apr 9, 2021
* add more phone numbers * set localized to True * add Card numbers add bank and credit_card providers. but need to change exp_date to Jalali datetime. * add utf-8 encoding * change name of credit_card providers to unicode * add color for fa_IR * add test for persian color * remove six package * sort imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this changes
translated colors to Persian
What was wrong
lack of Persian colors
How this fixes it
add fa_IR directory and init.py with translated Persian colors
Fixes #...