Support line breaks and comments in .env file #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The https://github.com/joke2k/django-environ/pull/283/files commit added useful warnings for skipped lines. However, it also started showing warnings for comment lines. Like in `.zshrc`, we add comments using hash (#). We also group common blocks together. Our env file was something like: ```env SECRET_KEY="S0M3#SecreT" DATABASE_URL=mysql://py-user:p@@sword@127.0.0.1:3306/db_name GOOGLE_CLIENT_ID="" GOOGLE_CLIENT_SECRET="" ```
|
Seconded, comments are great, our environment configs are totally separate from the code, so it's useful to have comments to explain expected values. |
|
As document( |
|
Today we updated to 0.8.0 and faced the same problem. Please add support for comments and blank lines. Thanks. Have a nice day. |
|
@mike667 I'm so sorry! It was my mistake, I did not carefully review the proposed feature. |
sergeyklay
approved these changes
Oct 19, 2021
|
@sergeyklay @pratyushmittal Thank you. |
|
Thank you for the patch! |
sergeyklay
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit #283 added useful warnings for skipped lines.
However, it also started showing warnings for comments.
Like in
.zshrc, we add comments using hash (#). We also group commonblocks together.
Our env files look something like:
I am not sure if the project intends to support comments.
Will request you please support them if possible :)