Generalize DI using AnnotatedFunction

[ludovicc]

Solves #25

[jokade]

@ludovicc Great work!
Could you please give me a short summary of the changes regarding AnnotatedFunction along with some use cases (so that I can update the README)?

On a side note, I have redesigned the directive API, since using a scala classes for directive controllers doesn't work out (the controller instance is created by Angular). I would be glad if you could give me your opinion on this -- the changes are located in the issue28 branch.

I hope that we can publish a 0.2 release within the week.

[jokade]

I have one minor concern regarding your refactoring: a value named angular within the package object angular could result in confusing compiler errors, if one imports biz.enef.angular instead of biz.enef.angular._. Maybe we should rename the Angular trait to NGand then use Angular as the name of the value in the package object? Another option would be to rename the entire package to ng (but that's a quite extensive change for such a minor issue).

[ludovicc]

Hi,

Good pick!
I would rename the whole package to 'angulate', since that's the name of
the library.

Otherwise, rename the angular value to 'ng'.

Ludovic

On 15/02/2015 14:30, jokade wrote:

I have one minor concern regarding your refactoring: a value named
|angular| within the package object |angular| could result in confusing
compiler errors, if one imports |biz.enef.angular| instead of
|biz.enef.angular._|. Maybe we should rename the |Angular| trait to
|NG|and then use |Angular| as the name of the value in the package
object? Another option would be to rename the entire package to |ng|
(but that's a quite extensive change for such a minor issue).

—
Reply to this email directly or view it on GitHub
#31 (comment).

[ludovicc]

On 15/02/2015 13:18, jokade wrote:

@ludovicc https://github.com/ludovicc Great work!
Could you please give me a short summary of the changes regarding
|AnnotatedFunction| along with some use cases (so that I can update the
README)?

On a side note, I have redesigned the directive API, since using a scala
classes for directive controllers doesn't work out (the controller
instance is created by Angular). I would be glad if you could give me
your opinion on this -- the changes are located in the |issue28| branch.

I hope that we can publish a 0.2 release within the week.

—
Reply to this email directly or view it on GitHub
#31 (comment).

I have documented AnnotatedFunction in the Readme.

[jokade]

Sorry, I didn't notice that your changes to the Readme...
I went ahead and renamed the base package to angulate.

[ludovicc]

Thanks for merging. I'm still reading about directives in Angular, I'll try to have some feedback by the end of the week.