Fix months order across timezones #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one! Thank you so much @pedromtcosta! |
theborakompanioni
approved these changes
Sep 27, 2024
|
@theborakompanioni my pleasure! Not trying to rush anything, but do you have any idea when I can expect a new build including this fix on Umbrel OS? |
ETA in October. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #852
The default
timeZoneforIntl.DateTimeFormatis based on the user's timezone, so because I'm behind UTC it get's shifted some hours back which leads to incorrect formatting of the month. Because we send the date in UTC toIntl.DateTimeFormatwe can set UTC explicitly as thetimeZoneto solve the issue.The test case
_selectableMonths / should display month namewas not passing on my end, and now it does.Also fixed a supposedly typo on the
describe('_selectableMonth')to reflect the correct name of the function that is being tested. I can adjust it back if you don't want unnecessary diff on the squashed commit.