Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev(setup): switch to docker compose v2 #784

Merged
merged 2 commits into from
Jul 4, 2024
Merged

dev(setup): switch to docker compose v2 #784

merged 2 commits into from
Jul 4, 2024

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Jun 18, 2024 •
edited
Loading

docker-compose (v1) is deprecated. docker compose (v2) should be used.
See Migrate to Compose V2.

How to test

Please verify that starting/stopping the development environment is still working for you.

  • npm run regtest:build
  • npm run regtest:up
  • npm run regtest:down
  • npm run regtest:clear

Tested with docker v26.1.4.

[user@host ~]$ docker --version
Docker version 26.1.4, build 5650f9b

@theborakompanioni theborakompanioni added the devtools Improvements in tooling label Jun 18, 2024
@theborakompanioni theborakompanioni self-assigned this Jun 18, 2024
@theborakompanioni theborakompanioni marked this pull request as ready for review June 21, 2024 11:05
amitx13
amitx13 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@amitx13 amitx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, everything is working fine with the migration to Docker Compose v2 as instructed.
Screenshot from 2024-07-04 18-35-23

@theborakompanioni theborakompanioni merged commit da8b0a9 into master Jul 4, 2024
3 checks passed
@theborakompanioni theborakompanioni deleted the chore/docker-compose-v2 branch July 4, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitx13 amitx13 amitx13 approved these changes

@0xSaksham 0xSaksham Awaiting requested review from 0xSaksham

@editwentyone editwentyone Awaiting requested review from editwentyone

@barrytra barrytra Awaiting requested review from barrytra

Assignees

@theborakompanioni theborakompanioni

Labels
devtools Improvements in tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theborakompanioni @amitx13